-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix performance for diamond dependencies #41
Comments
Seems that the solution is to move postpone the resubscribing (https://github.com/gerich-home/it-depends/blob/master/src/computed.ts#L113) until value.write ends. |
2803.88x - 😞 |
Yeah.. Working on it, has some ideas, similar in design to bulkChange.ts |
Maybe I'm wrong but it seems you forgot e.subscribe(function () {
}); for knockout setup after var e = ko.pureComputed(function() {
return d() % 2 == 0 ? b() : c();
}); Or it was in purpose? Because you have var s = e.onChange(function(){
}); for it-depends setup |
In this case performance logs become more real:
|
Correct... found it independently and pushed to branch diamond-performance |
See test from ee7a353
Perf results on my local machine are:
The text was updated successfully, but these errors were encountered: