Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix patching situation for #742 #795

Closed
wants to merge 7 commits into from
Closed

Fix patching situation for #742 #795

wants to merge 7 commits into from

Conversation

michaelkirk
Copy link
Member

@michaelkirk michaelkirk commented Apr 6, 2022

Please don't merge this. I just wanted to show an example of how to use the patches file when coordinating cross repo dependencies for #742.

Note: this includes the changes to WKT

@@ -12,4 +12,4 @@ edition = "2021"

[dependencies]
postgis = { version = ">=0.7.0, <0.9.0" }
geo-types = { version = "0.8.0", path = "../geo-types" }
geo-types = { version = "0.7", path = "../geo-types" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've learned it's usually the wrong idea to try to bump versions in a PR - instead use the patches section.

We'll bump the version as part of the release process.

@michaelkirk
Copy link
Member Author

This was just for demonstration. Closing.

@michaelkirk michaelkirk closed this Apr 6, 2022
@nyurik nyurik deleted the mkirk/dim branch April 6, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants