Use coord! macro instead of Coordinate ctor #760
Conversation
The `coord!` macro is much more flexible way to create a coordinate, and should be used in the same way as all other ones like `line_string` and `polygon`. This change is a noop for now, but in the future it will make it easier to introduce Z coordinate without substantial code change.
| /// | ||
| /// let point = Point(Coordinate { x: 1.5, y: 0.5 }); | ||
| /// let dot = point.dot(Point(Coordinate { x: 2.0, y: 4.5 })); | ||
| /// let point = Point(coord! { x: 1.5, y: 0.5 }); |
There was a problem hiding this comment.
I would prefer
let point = Point::new(1.5, 0.5);
in doc comments.
There was a problem hiding this comment.
thx @pka will fix. BTW, you can use the suggestion button to actually propose a change - will make it much easier to submit the changes. Use this button in the comment window
There was a problem hiding this comment.
@pka, I updated the PR, but TBH, I think this is wrong to introduce two unrelated changes in the same PR -- I was simply converting Coordinate {...} to coord! {...}, whereas this is technically a code change. A minor one, but these types of things we may probably want to do in a subsequent PRs
There was a problem hiding this comment.
@pka seems like it would create more problems than solve -- https://github.com/georust/geo/runs/5472344274?check_suite_focus=true -- so reverting. Let's keep changes to a minimum per above, and consider other changes separately.
error[E0283]: type annotations needed for `geo_types::Point<{float}>`
--> src/point.rs:237:13
|
6 | let point = Point::new(1.5, 0.5);
| ----- ^^^^^^^^^^ cannot infer type for type `{float}`
| |
| consider giving `point` the explicit type `geo_types::Point<{float}>`, where the type parameter `{float}` is specified
|
There was a problem hiding this comment.
How about using the geo::point! { x: , y: } macro?
There was a problem hiding this comment.
But yeah I'm fine keep it as you have written since you just did a find/replace, and this is unrelated
There was a problem hiding this comment.
@frewsxcv I agree that we should refactor it further in a subsequent PR, flattening macro usage. Feel free to r plus it when ready :)
This reverts commit 4a1f61e.
|
bors r+ |
|
Build succeeded: |
761: Use coord! macro instead of Coordinate ctor (part 2) r=frewsxcv a=nyurik This PR updates `geo` crate. See also #760. The `coord!` macro is much more flexible way to create a coordinate, and should be used in the same way as all other ones like `line_string` and `polygon`. This change is a noop for now, but in the future it will make it easier to introduce Z coordinate without substantial code change. - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - [ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Co-authored-by: Yuri Astrakhan <[email protected]>
Accidentally missed coord! macro cleanups after the georust#760 and georust#761
765: A few minor coord! followup cleanups r=frewsxcv a=nyurik Accidentally missed coord! macro cleanups after the #760 and #761 - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - ~[ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.~ --- Co-authored-by: Yuri Astrakhan <[email protected]>
Minor simplification of many `Point( coord! { ... })` into a more straightforward `point! { ... }` as initially proposed in prior PR georust#760 (review)
773: Simplify Point(coord!()) into point! r=frewsxcv a=nyurik
Minor simplification of many `Point( coord! { ... })` into a more straightforward `point! { ... }` as initially proposed in prior PR #760 (review)
- [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md).
- ~[ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.~
---
Co-authored-by: Yuri Astrakhan <[email protected]>
This PR updates the
geo-typescrate. See also #761.The
coord!macro is much more flexible way to create a coordinate, and should be used in the same way as all other ones likeline_stringandpolygon.This change is a noop for now, but in the future it will make it easier to introduce Z coordinate without substantial code change.
CHANGES.mdif knowledge of this change could be valuable to users.