Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: raise when using unaligned Series as a method argument #3271

Merged
merged 4 commits into from
Apr 28, 2024
Merged

API: raise when using unaligned Series as a method argument #3271

merged 4 commits into from
Apr 28, 2024

Conversation

martinfleis
Copy link
Member

Closes #3256

martinfleis
martinfleis commented Apr 27, 2024
View reviewed changes
geopandas/base.py
def _delegate_geo_method(op, this, *args, **kwargs):
def _delegate_geo_method(op, this, **kwargs):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restricting this to **kwargs only ensures we always have a key to be printed in the error message.

m-richards
m-richards approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@m-richards m-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Martin, left a comment on the actual error message, but otherwise makes sense to me. Just needs a changelog note.

jorisvandenbossche
jorisvandenbossche approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jorisvandenbossche jorisvandenbossche merged commit 6813f82 into geopandas:main Apr 28, 2024
19 of 20 checks passed
@martinfleis martinfleis deleted the align-parameters-error branch April 28, 2024 08:12
@martinfleis martinfleis mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@m-richards m-richards m-richards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: Series alignment for non binary op methods
3 participants
@martinfleis @jorisvandenbossche @m-richards