Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUID stuff unnecessary #654

Open
neworderofjamie opened this issue Jan 16, 2025 · 5 comments
Open

GUID stuff unnecessary #654

neworderofjamie opened this issue Jan 16, 2025 · 5 comments

Comments

@neworderofjamie
Copy link
Contributor

Previously the windows build system had to create GUIDs to hook projects together but this isn't required any more but the code remains. Remove!

@saadkhi
Copy link
Contributor

saadkhi commented Mar 19, 2025

I want to work on it please guide.

@neworderofjamie
Copy link
Contributor Author

So you will need access to a windows machine to test this one but it should be simply a matter of:

  1. Removing all the code for generating GUIDs (and the ObjBase header at the top) https://github.com/genn-team/genn/blob/master/src/genn/generator/generator.cc#L85-L124
  2. Removing the projectGUID parameter from https://github.com/genn-team/genn/blob/master/src/genn/genn/code_generator/generateMSBuild.cc#L15

@saadkhi
Copy link
Contributor

saadkhi commented Mar 19, 2025

oky, @neworderofjamie can you assign this issue to me

@saadkhi
Copy link
Contributor

saadkhi commented Mar 19, 2025

@neworderofjamie I have removed it. Now, I want to test it. Can you guide me through the testing process?

@neworderofjamie
Copy link
Contributor Author

I would test as follows:

  1. Open the GeNN solution in Visual Studio (https://github.com/genn-team/genn/blob/master/genn.sln) and try building it
  2. Install PyGeNN (https://genn-team.github.io/genn/documentation/5/installation.html) and check one of the user projects runs
  3. Make a PR and check the CI status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants