Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subxt doesn't support NonZero* types #1838

Closed
ark0f opened this issue Nov 15, 2022 · 5 comments
Closed

subxt doesn't support NonZero* types #1838

ark0f opened this issue Nov 15, 2022 · 5 comments
Assignees
Labels
C0-bug Something isn't working D1-core Gear Core D2-node Gear Node D5-tooling Helper tools and utilities P2-sometimesoon Medium priority

Comments

@ark0f
Copy link
Member

ark0f commented Nov 15, 2022

Problem

subxt doesn't support such types so we are limited in safety

Steps

.

Possible Solution

No response

Notes

No response

Relevant Log Output

Click to expand/collapse

<Paste your log here>

@ark0f ark0f added D1-core Gear Core D2-node Gear Node C0-bug Something isn't working D5-tooling Helper tools and utilities labels Nov 15, 2022
@clearloop
Copy link
Contributor

clearloop commented Apr 24, 2023

// TODO: use `NonZeroU64` after issue #1838 is fixed

do you mean this line @ark0f ? we actully can encode/decode the gas amount with NonZero* in subxt (or the rust API) as well! I assume renaming this issue to use NonZeroU64 for gas calculation is proper?

@ark0f
Copy link
Member Author

ark0f commented May 8, 2023

subxt codegen generates error when you changing corresponding field types to NonZeroU64:

The application panicked (crashed).
Message:  Unknown prelude type 'NonZeroU64'
Location: codegen/src/types/type_path.rs:130

@clearloop clearloop self-assigned this May 23, 2023
@clearloop clearloop added the P2-sometimesoon Medium priority label May 23, 2023
@clearloop
Copy link
Contributor

after #2667

@clearloop
Copy link
Contributor

paritytech/subxt#1012 has been merged, waiting for the next version now @ark0f

@clearloop
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C0-bug Something isn't working D1-core Gear Core D2-node Gear Node D5-tooling Helper tools and utilities P2-sometimesoon Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants