Issue 4281 - Simplify production code to add a transaction sync/asynchronously #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmit, delete FileReferenceStoreUpdates
patchwork01
approved these changes
Feb 25, 2025
gaffer01
reviewed
Feb 25, 2025
| @@ -41,7 +42,8 @@ public InitialisePartitionsTransaction(List<Partition> partitions) { | |||
| } | |||
|
|
|||
| /** | |||
| * Creates a transaction to initialise the table with a single root partition. | |||
| * Creates a transaction to initialise the table with a single pa0rtition covering all keys. This is the root | |||
There was a problem hiding this comment.
Spurious '0' in the word 'pa0rtition'.
gaffer01
reviewed
Feb 25, 2025
| * A transaction to set all partitions in a Sleeper table. This should specify the whole partition tree. Any partitions | ||
| * that were present before will be deleted. | ||
| * Sets all partitions in a Sleeper table. These should build into a complete partition tree, where all partitions are | ||
| * linked to a single root. Any partitions that were present before will be deleted. | ||
| */ |
There was a problem hiding this comment.
This would be clearer as "where there is a single root and all partitions are connected to that either directly or indirectly via other partitions".
gaffer01
approved these changes
Feb 25, 2025
…uction-code-to-add-a-transaction-sync-asynchronously
rtjd6554
deleted the
4281-Simplify-production-code-to-add-a-transaction-sync-asynchronously
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
PR"
Tests
Documentation
separate issue for that below.