Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4280 - State Store Update Wrapper #4298

Merged
merged 35 commits into from
Feb 21, 2025
Merged

Issue 4280 - State Store Update Wrapper #4298

merged 35 commits into from
Feb 21, 2025

Conversation

rtjd6554
Copy link
Collaborator

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests OR does not need testing for this extremely good reason:
    • Execution of existing tests editted

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added or removed any dependencies from the project, I have updated the NOTICES file.

patchwork01 and others added 30 commits February 20, 2025 14:37
@patchwork01
Use state store wrapper in some tests
80cba5b
@rtjd6554
Update the TransactionLogFileReferenceStoreIT with wrapper methods
e67f22a
@rtjd6554
Update all the instances of the clearFileData within tests classes to…
5f7a9a2 
… use the wrapper
@rtjd6554
Update wrapper usage for atomicallyReplaceFileReferencesWithNewOnes
e0294e9
@rtjd6554
Update splitFileReferences to use wrapper
43678a3
@rtjd6554
Update addFilesWithReferences to use wrapper
43d3e31
@rtjd6554
Update usage to wrapper for addFiles
c748b76
@rtjd6554
Remove un-needed character
c3287dd
@rtjd6554
Update wrapper usage for assignJobIds
fde8e3d
@rtjd6554
Update addfiles method to use wrapper
2f36603
@rtjd6554
Update atomicallyUpdatePartitionAndCreateNewOnes from PartitionStore …
4e6e3d3 
…to use wrapper
@rtjd6554
Partially update initialise for PartitionStore to wrapper
9c3434a
@patchwork01
Use addTransaction in SystemTestIngestToStateStore
5a1ad82
@patchwork01
Adjust use of initialise(Schema)
93155d0
@patchwork01
Remove unused method
c08dc4f
@patchwork01
Remove mocking in BulkImportJobDriverTest
efbc957
@patchwork01
Use wrapper in StateStoreCommitterThroughputST
c6cdc2f
@patchwork01
Work on ECSCompactionTaskRunnerLocalStackIT
5e93c64
@rtjd6554
Update functionality for shouldPutMessageBackOnSQSQueueIfStateStoreUp…
1f4ef89 
…dateFailed
@patchwork01
Add helpers for in memory state store
7230096
@patchwork01
Remove mocking from ECSCompactionTaskRunnerLocalStackIT
ce7f6a7
@patchwork01
Remove atomicallyReplaceFileReferencesWithNewOnes in InMemoryCompaction
7315580
@patchwork01
Use wrapper for atomicallyReplaceFileReferencesWithNewOnes
9c90d14
@patchwork01
Use wrapper for clearSleeperTable call
f1f2392
@patchwork01
Use wrapper for initialise call in tests
384f448
@patchwork01
Use wrapper for initialise call in system test DSL tests
6d0bf45
@patchwork01
Copy from TransactionLogPartitionStoreTest to TransactionLogPartition…
94b879a 
…StoreIT
@patchwork01
Use wrapper for initialise calls in tests
bb3f6d2
@patchwork01
Remove more references to initialise
02dd4d7
@patchwork01
Remove unused dependency
745aaa0
@patchwork01 patchwork01 marked this pull request as ready for review February 21, 2025 14:04
@rtjd6554 rtjd6554 merged commit dbbb4d7 into develop Feb 21, 2025
9 checks passed
@rtjd6554 rtjd6554 deleted the 4280-state-store-update-wrapper branch February 21, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patchwork01 patchwork01 patchwork01 approved these changes

Assignees

@rtjd6554 rtjd6554

Labels
one-review-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply state store wrapper for updates to all tests
2 participants
@rtjd6554 @patchwork01