Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop job run model caring about update types #4291

Closed
patchwork01 opened this issue Feb 20, 2025 · 0 comments · Fixed by #4294
Closed

Stop job run model caring about update types #4291

patchwork01 opened this issue Feb 20, 2025 · 0 comments · Fixed by #4294
Assignees
Milestone

Comments

@patchwork01
Copy link
Collaborator

Background

Split from:

In JobRun.Builder.statusUpdate, we currently check the type of the update so that we can report on whether the job is finished and give a summary of the run. This includes calling JobRunStartedUpdate.isStartOfRun, which we want to remove.

Description

We'd like to remove the type checks in JobRun, and make this type detection specific to ingest and compaction instead. That way we can be more explicit about the differences between an ingest job run and a compaction job run.

This should also make it more feasible to remove JobRunStartedUpdate.isStartOfRun, as in the linked issue.

Analysis

We can create a CompactionJobRun and an IngestJobRun, and return those from CompactionJobStatus and IngestJobStatus instead of JobRun.

@patchwork01 patchwork01 added the enhancement New feature or request label Feb 20, 2025
@patchwork01 patchwork01 added this to the 0.29.0 milestone Feb 20, 2025
@patchwork01 patchwork01 self-assigned this Feb 20, 2025
@patchwork01 patchwork01 removed the enhancement New feature or request label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant