Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan approach to GHCR image problem / CLI / Docker images #2684

Closed
patchwork01 opened this issue Jun 12, 2024 · 0 comments
Closed

Plan approach to GHCR image problem / CLI / Docker images #2684

patchwork01 opened this issue Jun 12, 2024 · 0 comments

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Jun 12, 2024

Background

We've had problems with the Docker implementation of the Sleeper CLI as the Docker images keep getting deleted from GHCR:

We're also likely to replace the current Sleeper CLI, scripts and admin client with a version that runs directly in Java:

Description

We'd like to decide what we should do with the Docker images that are currently held in GHCR, and how we should deal with the linked bug in GHCR. We'd like to understand how this relates to our plans for the CLI and admin client.

Analysis

We could handle this as part of the linked epic (#1328). That could replace the Docker-based CLI entirely.

Possible replacements

The sleeper builder Docker image could be replaced entirely with Nix, as in #2683 and #2826.

The sleeper environment Docker image could be combined into the Java-based CLI, which could handle retrieving and running the cdk-environment CDK app.

The sleeper deployment Docker image should no longer be needed if we combine all the scripts into a single Java-based CLI. It can retrieve the separate jars as they are needed. It's also not often used, and will be removed in #2751.

We could store the jars somewhere instead of the Docker images. GitHub Packages may be suitable for this.

Single image tag

Rather than get rid of the images entirely, we could only have one set of images which are the latest version. We can design it so that there's no need for any older version. At time of writing, we've removed the deployment Docker image, so there's no link between the CLI and any particular released version of Sleeper.

The following issue should resolve this:

Combined with the linked epic to improve and unify the clients, this should resolve the problem:

@patchwork01 patchwork01 added this to the 0.24.0 milestone Jun 12, 2024
@patchwork01 patchwork01 changed the title Plan resolution to GHCR image problem Plan approach to GHCR image problem / CLI / Docker images Jun 12, 2024
@gaffer01 gaffer01 removed this from the 0.24.0 milestone Jun 17, 2024
@patchwork01 patchwork01 added this to the 0.25.0 milestone Jul 31, 2024
@gaffer01 gaffer01 removed this from the 0.25.0 milestone Aug 8, 2024
@gaffer01 gaffer01 closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants