Skip to content

Commit

Permalink
refactor(PointCloudLayer): delete onPointsCreated callback
Browse files Browse the repository at this point in the history
  • Loading branch information
ftoromanoff authored and Desplandis committed Dec 20, 2024
1 parent b2bcb7f commit 628ed94
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 6 deletions.
4 changes: 0 additions & 4 deletions src/Layer/PointCloudLayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -328,10 +328,6 @@ class PointCloudLayer extends GeometryLayer {
redraw: true,
earlyDropFunction: cmd => !cmd.requester.visible || !this.visible,
}).then((pts) => {
if (this.onPointsCreated) {
this.onPointsCreated(layer, pts);
}

elt.obj = pts;
// store tightbbox to avoid ping-pong (bbox = larger => visible, tight => invisible)
elt.tightbbox = pts.tightbbox;
Expand Down
1 change: 0 additions & 1 deletion test/unit/potree.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ describe('Potree', function () {
// Configure Point Cloud layer
potreeLayer = new PotreeLayer('lion_takanawa', {
source,
onPointsCreated: () => {},
crs: viewer.referenceCrs,
});

Expand Down
1 change: 0 additions & 1 deletion test/unit/potree2.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ describe('Potree2', function () {
url: 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/pointclouds/potree2.0/lion',
networkOptions: process.env.HTTPS_PROXY ? { agent: new HttpsProxyAgent(process.env.HTTPS_PROXY) } : {},
}),
onPointsCreated: () => {},
crs: viewer.referenceCrs,
});

Expand Down

0 comments on commit 628ed94

Please sign in to comment.