fix(GlobeView): remove default directional light

gchoqueux · Oct 25, 2024 · 0a098af · 0a098af
1 parent 565ba36
commit 0a098af
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/examples/3dtiles_loader.html b/examples/3dtiles_loader.html
@@ -100,7 +100,7 @@
             itowns.enableKtx2Loader('./lib/basis/', view.renderer);
 
             // Add ambient light to globally illuminates all objects
-            const light = new AmbientLight(0x404040, 15);
+            const light = new AmbientLight(0x404040, 40);
             view.scene.add(light);
 
             // Setup loading screen

diff --git a/src/Core/Prefab/GlobeView.js b/src/Core/Prefab/GlobeView.js
@@ -96,11 +96,6 @@ class GlobeView extends View {
         const tileLayer = new GlobeLayer('globe', options.object3d, options);
         this.mainLoop.gfxEngine.label2dRenderer.infoTileLayer = tileLayer.info;
 
-        const sun = new THREE.DirectionalLight();
-        sun.position.set(-0.5, 0, 1);
-        sun.updateMatrixWorld(true);
-        this.scene.add(sun);
-
         this.addLayer(tileLayer);
         this.tileLayer = tileLayer;
 

diff --git a/test/functional/source_file_gpx_3d.js b/test/functional/source_file_gpx_3d.js
@@ -11,6 +11,6 @@ describe('source_file_gpx_3d', function _() {
     });
 
     it('should wait for the mesh to be added to the scene', async function _it() {
-        await page.waitForFunction(() => view.scene.children.length === 5, { timeout: 10000 });
+        await page.waitForFunction(() => view.scene.children.length === 4, { timeout: 10000 });
     });
 });