Roundabouts bug in osm_xml #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like tests are failing. |
Codecov Report
@@ Coverage Diff @@
## main #986 +/- ##
==========================================
+ Coverage 97.91% 98.00% +0.09%
==========================================
Files 24 23 -1
Lines 2395 2408 +13
==========================================
+ Hits 2345 2360 +15
+ Misses 50 48 -2
|
|
Sorry I was being lazy and using the github continuous integration to do my testing ;). Will test locally before my next push. |
|
@mxndrwgrdnr thanks. Would you add a line to the change log documenting this change? |
|
Done! |
|
Looks like the latest failures are just a 502 error from nominatim. I'll wait a bit and try to trigger the build again. |
No worries, I just re-ran them successfully. Thank you! |
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #970. Handles NetworkX topology violation when converting ways to DAGs in osm_xml.py No new usage required.