Restore CXX_STANDARD 17 in core library #1072
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Restore
CXX_STANDARD
export in core library that was removed in #1059 and also tests gazebosim/gz-cmake#273Summary
This is mainly testing gazebosim/gz-cmake#273 using the
ci_matching_branch/
trickery with osrf/homebrew-simulation@406b74a and gazebo-tooling/gazebodistro@b427433, but it does make a small improvement of its own, restoring theCXX_STANDARD
export. The main things changed in gazebosim/gz-cmake#273 is findingIgnURDFDOM
changes toGzURDFDOM
, but there may be an issue with the target names not being migrated. This is a draft PR until that is confirmed.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.