From 4f09e7b74c052b12986c9d81d3e07f1b5f32b8c2 Mon Sep 17 00:00:00 2001 From: Stephen Brawner Date: Mon, 4 Jan 2021 16:07:15 -0800 Subject: [PATCH] Remove variable deprecation, revert root_dom integration test --- src/Root.cc | 6 +++--- test/integration/root_dom.cc | 18 ++++++++++++++++++ 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/src/Root.cc b/src/Root.cc index 8529a2370..8b33f9d85 100644 --- a/src/Root.cc +++ b/src/Root.cc @@ -52,15 +52,15 @@ class sdf::RootPrivate /// \brief The models specified under the root SDF element /// Deprecated: to be removed in libsdformat12 - public: std::vector models SDF_DEPRECATED(11.0); + public: std::vector models; /// \brief The lights specified under the root SDF element /// Deprecated: to be removed in libsdformat12 - public: std::vector lights SDF_DEPRECATED(11.0); + public: std::vector lights; /// \brief The actors specified under the root SDF element /// Deprecated: to be removed in libsdformat12 - public: std::vector actors SDF_DEPRECATED(11.0); + public: std::vector actors; /// \brief Frame Attached-To Graphs constructed when loading Worlds. public: std::vector> diff --git a/test/integration/root_dom.cc b/test/integration/root_dom.cc index 2c09dd178..4fefe7e31 100644 --- a/test/integration/root_dom.cc +++ b/test/integration/root_dom.cc @@ -91,6 +91,19 @@ TEST(DOMRoot, LoadMultipleModels) EXPECT_TRUE(errors.empty()) << errors; ASSERT_NE(nullptr, root.Model()); EXPECT_EQ("robot1", root.Model()->Name()); + + SDF_SUPPRESS_DEPRECATED_BEGIN + EXPECT_EQ(3u, root.ModelCount()); + + EXPECT_EQ("robot1", root.ModelByIndex(0)->Name()); + EXPECT_EQ("robot2", root.ModelByIndex(1)->Name()); + EXPECT_EQ("last_robot", root.ModelByIndex(2)->Name()); + + EXPECT_FALSE(root.ModelNameExists("robot")); + EXPECT_TRUE(root.ModelNameExists("robot1")); + EXPECT_TRUE(root.ModelNameExists("robot2")); + EXPECT_TRUE(root.ModelNameExists("last_robot")); + SDF_SUPPRESS_DEPRECATED_END } ///////////////////////////////////////////////// @@ -105,4 +118,9 @@ TEST(DOMRoot, LoadDuplicateModels) EXPECT_FALSE(errors.empty()); EXPECT_NE(nullptr, root.Model()); EXPECT_EQ("robot1", root.Model()->Name()); + + SDF_SUPPRESS_DEPRECATED_BEGIN + EXPECT_EQ(1u, root.ModelCount()); + EXPECT_EQ("robot1", root.ModelByIndex(0)->Name()); + SDF_SUPPRESS_DEPRECATED_END }