Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz Namespace Migration : gz-utils #61

Merged
merged 22 commits into from
May 28, 2022
Merged

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon force-pushed the namespace_migration branch 3 times, most recently from 7dbb653 to e1db186 Compare May 17, 2022 01:01
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 17, 2022
@methylDragon methylDragon force-pushed the namespace_migration branch 7 times, most recently from c8fa4c0 to 3495f2b Compare May 18, 2022 01:46
@methylDragon methylDragon force-pushed the namespace_migration branch from 2d67eac to 5e26778 Compare May 19, 2022 20:54
methylDragon and others added 8 commits May 19, 2022 15:58
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the namespace_migration branch from f944927 to 53b3d1a Compare May 19, 2022 22:59
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing that we could fix in follow up PRs. Everywhere that's user-facing, like documentation and UI, should use "Gazebo". Everything that's in the code should be gz

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this branch with ign-math, and it breaks because ign-math has already switched to the gz/utils/* headers but not the gz:: namespace

Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the namespace_migration branch from 8e8961f to 7bab84e Compare May 20, 2022 01:00
@chapulina
Copy link
Contributor

I just tested this branch with ign-math, and it breaks because ign-math has already switched to the gz/utils/* headers but not the gz:: namespace

As discussed, to reduce the number of rounds of PRs, we'll go ahead and merge this series topologically, leaving downstream libraries broken in the meantime. We'll plan to do it at a time that disrupts the least people and will test all PRs together well before doing so. This should save us more rounds of PRs.

Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include/ignition/utils.hh also needs to do the following: #include <ignition/utils/config.hh>, add the using namespace statement and pragma warning

@methylDragon
Copy link
Contributor Author

include/ignition/utils.hh also needs to do the following: #include <ignition/utils/config.hh>, add the using namespace statement and pragma warning

102e7fd

I found a bug in my script, that's been fixed, and propagated across all repos.

@scpeters
Copy link
Member

include/ignition/utils.hh also needs to do the following: #include <ignition/utils/config.hh>, add the using namespace statement and pragma warning

102e7fd

I found a bug in my script, that's been fixed, and propagated across all repos.

sorry I just found one last one:

Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
@chapulina chapulina merged commit cdd48b3 into main May 28, 2022
@chapulina chapulina deleted the namespace_migration branch May 28, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants