-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ign -> gz Namespace Migration : gz-utils #61
Conversation
7dbb653
to
e1db186
Compare
c8fa4c0
to
3495f2b
Compare
2d67eac
to
5e26778
Compare
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
f944927
to
53b3d1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing that we could fix in follow up PRs. Everywhere that's user-facing, like documentation and UI, should use "Gazebo". Everything that's in the code should be gz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested this branch with ign-math, and it breaks because ign-math has already switched to the gz/utils/*
headers but not the gz::
namespace
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
8e8961f
to
7bab84e
Compare
As discussed, to reduce the number of rounds of PRs, we'll go ahead and merge this series topologically, leaving downstream libraries broken in the meantime. We'll plan to do it at a time that disrupts the least people and will test all PRs together well before doing so. This should save us more rounds of PRs. |
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include/ignition/utils.hh
also needs to do the following: #include <ignition/utils/config.hh>
, add the using namespace
statement and pragma warning
Signed-off-by: methylDragon <[email protected]>
I found a bug in my script, that's been fixed, and propagated across all repos. |
sorry I just found one last one: |
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
See gazebo-tooling/release-tools#711
Supercedes #50