Remove visibility from headers that are not installed

[chapulina]

🦟 Bug fix

Summary

Backporting part of the changes from #501.

I believe it should be fine to change the visibility of classes that are not installed in a stable distribution, let's see what the ABI checker says.

The motivation is to make forward-porting changes easier. On #622 we had to make lots of changes for the code ported from Dome to Edifice to work on Windows. If we encourage proper usage of visibility flags from Citadel, new plugins should use correct boilerplate from the beginning.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #665 (bdd9e9e) into ign-gazebo3 (b47e7e5) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           ign-gazebo3     #665      +/-   ##
===============================================
- Coverage        77.87%   77.82%   -0.05%     
===============================================
  Files              212      210       -2     
  Lines            11719    11649      -70     
===============================================
- Hits              9126     9066      -60     
+ Misses            2593     2583      -10     

Impacted Files	Coverage Δ
src/Conversions.cc	81.57% <ø> (ø)
src/network/PeerTracker.hh	100.00% <ø> (ø)
src/systems/apply_joint_force/ApplyJointForce.hh	100.00% <ø> (ø)
src/systems/breadcrumbs/Breadcrumbs.hh	100.00% <ø> (ø)
src/systems/buoyancy/Buoyancy.hh	100.00% <ø> (ø)
src/systems/contact/Contact.hh	100.00% <ø> (ø)
src/systems/detachable_joint/DetachableJoint.hh	100.00% <ø> (ø)
src/systems/diff_drive/DiffDrive.hh	100.00% <ø> (ø)
src/systems/joint_controller/JointController.hh	100.00% <ø> (ø)
...int_position_controller/JointPositionController.hh	100.00% <ø> (ø)
... and 28 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47e7e5...af40f5c. Read the comment docs.

[chapulina]

ABI checker is happy, opening for review (CC @j-rivero )

[j-rivero]

Most of the changes looks good to me. Just curious about what made us to add visibiltiy to template functions in a private non-header file. Running a quick test removing them here

[chapulina]

Just curious about what made us to add visibiltiy to template functions in a private non-header file.

See your comment here: #563 (comment)

Running a quick test removing them here

Do you have the build number? What branch were you testing? Because I think ign-gazebo3 may have other problems on Windows.

[j-rivero]

Do you have the build number? What branch were you testing? Because I think ign-gazebo3 may have other problems on Windows.

This one: https://build.osrfoundation.org/job/ign_gazebo-pr-win/2351/consoleFull#1992467405aa60f765-a60a-427d-900c-dc128ab22287

Just curious about what made us to add visibiltiy to template functions in a private non-header file.

See your comment here: #563 (comment)

aaah ok. I remember that there was a reason for it. Thanks!