Fix ResourceSpawner

[mjcarroll]

🦟 Bug fix

Fixes #2486

Summary

id.UniqueName() now returns without https:// prefixed, but we want to keep track of the URIs that the resources are downloaded from. These changes were added in gazebosim/gz-fuel-tools#376 and should have been accommodated here.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages

[azeey]

Thanks for the fix. Just one issue

[azeey]

Can we avoid hard coding https://? Maybe get it from server somehow?

[mjcarroll]

Actually looking at this again, the UniqueName won't work on Windows (though gui plugins currently don't have any test coverage). Let me re-work it.

[mjcarroll]

Okay, I ended up adding a Url method to the Identifier objects in fuel_tools. This now depends on gazebosim/gz-fuel-tools#429

[logocar3]

Disclaimer - outsider needing this bug to be fixed.

There is Url property in ServerConfig object.

Change the line, where build fails:
742 | resource.sdfPath = id.Url().Str();

Into
742 | resource.sdfPath = id.Server().Url().Str();

Regards

[mjcarroll]

There is Url property in ServerConfig object.

That URL only stores the base server URL. In this case, we need the full URL to the asset in question.

[azeey]

@mjcarroll looks like this needs a gz-fuel-tool9 release.

[usmanNoor5]

[ruby $(which gz) sim-2] Error [SDF.cc:165] Tried to use callback in sdf::findFile(), but the callback is empty. Did you call sdf::setFindCallback()?

how to handle this problem