-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCC/CMake warnings for Noble #2375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
GCC is emitting a warning about a possible danling pointer on table like definitions: warning: possibly dangling reference to a temporary [-Wdangling-reference] 660 | auto const& table = get_current_events_table(state_indexes{}); | ^~~~~ Which I think that really comes from the use of state_indexes{} as argument: note: the temporary was destroyed at the end of the full expression 660 | auto const& table = get_current_events_table(state_indexes{}); | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ Clang is quiet about this and make me think that is a false positive since the metaprogramming code is using just the type of the state_indexes as much as I can see. Signed-off-by: Jose Luis Rivero <[email protected]>
caguero
approved these changes
Apr 17, 2024
ahcorde
requested changes
Apr 17, 2024
src/systems/elevator/vender/afsm/include/afsm/detail/transitions.hpp
Outdated
Show resolved
Hide resolved
src/systems/elevator/vender/afsm/include/afsm/detail/transitions.hpp
Outdated
Show resolved
Hide resolved
src/systems/elevator/vender/afsm/include/afsm/detail/transitions.hpp
Outdated
Show resolved
Hide resolved
…ns.hpp Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>
…ns.hpp Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>
…ns.hpp Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Fix the CMake and GCC warnings that appeared when building on Noble. Each of the three commits is self-explanatory for review. The most tropical change is the 55498d807af68e18f5850f41adadbac3d7f5e9, quoting the commit description:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.