Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GPU based ray queries on mac #758

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Nov 8, 2022

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

Enable GPU based ray queries on macOS since we now have the metal shaders in place, see #747.

I tested locally on my mac and mouse picking, camera control, and transform control are working.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #758 (701d917) into gz-rendering7 (a702e51) will increase coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           gz-rendering7     #758   +/-   ##
==============================================
  Coverage          74.46%   74.46%           
==============================================
  Files                164      164           
  Lines              14363    14363           
==============================================
+ Hits               10695    10696    +1     
+ Misses              3668     3667    -1     
Impacted Files Coverage Δ
ogre2/src/Ogre2RayQuery.cc 61.20% <ø> (ø)
include/gz/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033 iche033 merged commit 341276b into gz-rendering7 Nov 11, 2022
@iche033 iche033 deleted the rayquery_macos branch November 11, 2022 20:04
@iche033 iche033 mentioned this pull request Nov 11, 2022
9 tasks
@Crola1702
Copy link
Contributor

Crola1702 commented Nov 28, 2022

Hi There!
I think this PR may have introduced a new Test regression on gz-rendering7

Reference build: https://build.osrfoundation.org/job/ignition_rendering-ci-gz-rendering7-homebrew-amd64/28/

Test regression on INTEGRATION_scene_ogre2_metal: SceneTest.VisualAt

Log output:

37: [Dbg] [CommonRenderingTest.hh:69] Using OGRE2-METAL backend to test
37: [Msg] Loading plugin [gz-rendering-ogre2]
37: /Users/jenkins/workspace/ignition_rendering-ci-gz-rendering7-homebrew-amd64/ign-rendering/test/integration/scene.cc:174: Failure
37: Expected: (nullptr) != (sphere_visual), actual: (nullptr) vs (nullptr)
37: [  FAILED  ] SceneTest.VisualAt (528 ms)

I checked if CI passed without these changes, and they did:

Check changes with PR: Build Status Build Status

Check changes without PR: Build Status Build Status

I ran a build today to check if this issue is still a problem: Build Status

As you can see, it is still an issue. Do you have any thoughts on this one? (@iche033 @ahcorde)

FYI: @Blast545


I think #762 solved this issue

No, it didn't (#33 failed). It seems it's a flaky one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants