Fix for #578 on macOS / Metal

[srmainwaring]

🦟 Bug fix

Fix issue for macOS / Metal introduced in #578

Summary

#578 introduced an error on macOS / Metal for a number of examples where the parameters for the pixel shader
could not be set because the reflection pair hint was not available. This PR moves the block of code causing the issue to after the vertex shader has been created and reflection pair hint has been set.

See comment here:

• Respect vertex shader from low level materials in sensor passes (#544) #578 (comment)

Test outcome here:

• Respect vertex shader from low level materials in sensor passes (#544) #578 (comment)

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #588 (63c9939) into main (23955a9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   53.43%   53.43%           
=======================================
  Files         214      214           
  Lines       21301    21301           
=======================================
  Hits        11383    11383           
  Misses       9918     9918           

Impacted Files	Coverage Δ
ogre2/src/Ogre2Material.cc	73.84% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23955a9...63c9939. Read the comment docs.

[iche033]

looks good to me. Thanks for the fix.