Fix missing terrain shadows casted on objects #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue was incorrect listener setup due to bad merge. ign-rendering7 has a more robust system to handle all listeners. For Fortress this fix will do. Signed-off-by: Matias N. Goldberg <[email protected]>
darksylinc
force-pushed
the
matias-missingShadows
branch
from
17f3325 to
9c4c31c
Compare
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #547 +/- ##
==================================================
+ Coverage 54.37% 54.47% +0.09%
==================================================
Files 198 198
Lines 20096 20099 +3
==================================================
+ Hits 10928 10948 +20
+ Misses 9168 9151 -17
Continue to review full report at Codecov.
|
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
No ticket assigned; but it was mentioned in #536 (comment)
Summary
Issue was incorrect listener setup due to bad merge.
ign-rendering7 has a more robust system to handle all listeners. For
Fortress this fix will do.
Garden will already have a better fix after PR #545 is merged.
The code that should not be carried over to Garden was surrounded by
#ifdefmacros and an assert was placed. Hopefully that will help reducing merge conflict mistakes.Signed-off-by: Matias N. Goldberg [email protected]
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.