-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.5.0 #254
4.5.0 #254
Conversation
Signed-off-by: Ashton Larkin <[email protected]>
5ad0e4a
to
531d37d
Compare
Codecov Report
@@ Coverage Diff @@
## ign-rendering4 #254 +/- ##
===============================================
Coverage 53.29% 53.29%
===============================================
Files 143 143
Lines 13672 13672
===============================================
Hits 7286 7286
Misses 6386 6386 Continue to review full report at Codecov.
|
It looks like the depth camera integration test is failing on Ubuntu Bionic for GitHub actions, but passes in the other checks:
I noticed the sane failure in #251, but thought it was a false positive at first. Now that I am seeing the same failure happen again here, I'm not so sure. It could potentially be precision issue with GitHub actions. All of the failures look something like this (
|
It's a flaky test. All tests are green. |
Signed-off-by: Ashton Larkin <[email protected]>
e8e9765
to
8252ce4
Compare
Signed-off-by: Ashton Larkin [email protected]
🎈 Release
Preparation for
4.5.0
release.Comparison to
4.4.0
: ignition-rendering4_4.4.0...ign-rendering4Needed by:
Checklist
Note to maintainers: Remember to use Squash-Merge