Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.5.0 #254

Merged
merged 1 commit into from
Feb 18, 2021
Merged

4.5.0 #254

merged 1 commit into from
Feb 18, 2021

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Feb 17, 2021

Signed-off-by: Ashton Larkin [email protected]

🎈 Release

Preparation for 4.5.0 release.

Comparison to 4.4.0: ignition-rendering4_4.4.0...ign-rendering4

Needed by:

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

@adlarkin adlarkin requested review from nkoenig and iche033 February 17, 2021 23:50
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Feb 17, 2021
adlarkin added a commit that referenced this pull request Feb 17, 2021
Signed-off-by: Ashton Larkin <[email protected]>
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #254 (8252ce4) into ign-rendering4 (b2e747b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering4     #254   +/-   ##
===============================================
  Coverage           53.29%   53.29%           
===============================================
  Files                 143      143           
  Lines               13672    13672           
===============================================
  Hits                 7286     7286           
  Misses               6386     6386           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e747b...8252ce4. Read the comment docs.

@adlarkin
Copy link
Contributor Author

It looks like the depth camera integration test is failing on Ubuntu Bionic for GitHub actions, but passes in the other checks:

The following tests FAILED:
  	 64 - INTEGRATION_depth_camera (Failed)

I noticed the sane failure in #251, but thought it was a false positive at first. Now that I am seeing the same failure happen again here, I'm not so sure.

It could potentially be precision issue with GitHub actions. All of the failures look something like this (DEPTH_TOL is 1e-4):

  /github/workspace/test/integration/depth_camera.cc:653: Failure
  Value of: ignition::math::equal(expectedParticleDepth, xd, depthNoiseTol) || ignition::math::equal(expectedDepth, xd, DEPTH_TOL)
    Actual: false
  Expected: true
  actual vs expected particle depth: 1.2035391330718994 vs 1

@nkoenig
Copy link
Contributor

nkoenig commented Feb 18, 2021

It's a flaky test. All tests are green.

@adlarkin
Copy link
Contributor Author

I just spoke with @iche033, it seemed to be an issue with the depth tolerance and noise standard deviation. It should be fixed in e8e9765, so I'll merge when the required checks are done.

Signed-off-by: Ashton Larkin <[email protected]>
@adlarkin adlarkin merged commit 8252ce4 into ign-rendering4 Feb 18, 2021
@adlarkin adlarkin deleted the adlarkin/4.5.0 branch February 18, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants