Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused files (bitbucket-pipelines, docs) #273

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jul 12, 2022

🦟 Bug fix

Summary

The bitbucket-pipelines file hasn't been needed for a long time.

The docs directory isn't being used to generate documentation, it isn't even being build by CMake. Instead, we've been using gz-cmake. I checked locally with this branch that the documentation is correctly generated with this branch:

colcon build --cmake-target doc --packages-select-regex=.*fuel
# open build/ignition-fuel_tools4/doxygen/html/index.html in a browser

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from nkoenig as a code owner July 12, 2022 22:31
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jul 12, 2022
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #273 (44752f4) into ign-fuel-tools4 (2010890) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ign-fuel-tools4     #273   +/-   ##
================================================
  Coverage            76.15%   76.15%           
================================================
  Files                   19       19           
  Lines                 2718     2718           
================================================
  Hits                  2070     2070           
  Misses                 648      648           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2010890...44752f4. Read the comment docs.

@chapulina chapulina merged commit 5146db9 into ign-fuel-tools4 Jul 13, 2022
@chapulina chapulina deleted the chapulina/4/unused branch July 13, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants