Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ign-fuel-tools4 ➡️ ign-fuel-tools7 #260

Merged
merged 4 commits into from
Jun 7, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-fuel-tools4 ➡️ ign-fuel-tools7

Branch comparision: ign-fuel-tools7...ign-fuel-tools4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 4 commits May 13, 2022 17:25
@chapulina chapulina requested a review from nkoenig as a code owner June 7, 2022 00:50
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 7, 2022
@chapulina chapulina requested a review from Blast545 June 7, 2022 00:51
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ign-fuel-tools7@21c5eb5). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             ign-fuel-tools7     #260   +/-   ##
==================================================
  Coverage                   ?   73.82%           
==================================================
  Files                      ?       20           
  Lines                      ?     2862           
  Branches                   ?        0           
==================================================
  Hits                       ?     2113           
  Misses                     ?      749           
  Partials                   ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c5eb5...f019a87. Read the comment docs.

Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise LGTM

@chapulina chapulina merged commit b3c253c into ign-fuel-tools7 Jun 7, 2022
@chapulina chapulina deleted the chapulina/4_to_7 branch June 7, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants