feat: add generator meta tag for gatsby version #8221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
reviewed
Sep 17, 2018
| @@ -8,6 +8,7 @@ const { get, merge, isObject, flatten, uniqBy } = require(`lodash`) | |||
| const apiRunner = require(`./api-runner-ssr`) | |||
| const syncRequires = require(`./sync-requires`) | |||
| const { dataPaths, pages } = require(`./data.json`) | |||
| const { version: gatsbyVersion } = require(join(process.cwd(), 'node_modules/gatsby/package.json')) | |||
There was a problem hiding this comment.
I wonder if we can just do require(`gatsby/package.json`)?
There was a problem hiding this comment.
We sure can! Thank you :)
DSchau
changed the title
| @@ -12,6 +12,7 @@ export default class HTML extends React.Component { | |||
| name="viewport" | |||
| content="width=device-width, initial-scale=1, shrink-to-fit=no" | |||
| /> | |||
| {this.props.gatsbyVersion && <meta name="generator" content={`Gatsby ${this.props.gatsbyVersion}`} />} | |||
| {this.props.headComponents} | |||
There was a problem hiding this comment.
Instead of adding it to the default html component (which is often overrided), set it as a component in headComponents
There was a problem hiding this comment.
I was so close to doing it this way instead 🙃 Will do it that way, one sec
|
Also could we use something like this: gatsby/packages/gatsby/cache-dir/static-entry.js Lines 274 to 282 in cf7fd8a so people with custom html.js don't miss out on this head element? :) (we can get away with extra props)
|
DSchau
commented
Sep 17, 2018
| @@ -50,7 +51,9 @@ const createElement = React.createElement | |||
|
|
|||
| export default (pagePath, callback) => { | |||
| let bodyHtml = `` | |||
| let headComponents = [] | |||
| let headComponents = [ | |||
There was a problem hiding this comment.
I think this is OK?
This ends up putting it after some things like style elements and stuff in the head tags, which is probably fine.
i.e.
<style>
/* snipped */
</style>
<meta name="generator" content="Gatsby 2.0.0-rc.26"/>
<title data-react-helmet="true">Reproduction of #7590</title>
<meta data-react-helmet="true" name="description" content="Sample"/>
<meta data-react-helmet="true" name="keywords" content="sample, something"/>
<style type="text/css"></style>There was a problem hiding this comment.
yeah, the order doesn't matter
| @@ -32,6 +32,7 @@ HTML.propTypes = { | |||
| htmlAttributes: PropTypes.object, | |||
| headComponents: PropTypes.array, | |||
| bodyAttributes: PropTypes.object, | |||
| gatsbyVersion: PropTypes.string, | |||
There was a problem hiding this comment.
Thanks! (and done)
yamgent
pushed a commit
to MarkBind/markbind
that referenced
this pull request
Mar 14, 2019
The Agolia team has requested that we add <meta name="generator"> (#754) tags to identify pages generated by MarkBind. Since this tag is part of HTML5 [1] and can be used by other external providers to identify MarkBind generated sites, we can include this tag in all MarkBind pages. We can also include the version number to allow tracking the use of different MarkBind versions, as other projects have done [2, 3]. Let's include the <meta name="generator"> tag to identify MarkBind pages, as well as including the version number to track the use of different MarkBind versions. [1]: https://www.w3.org/TR/html5/document-metadata.html#generator [2]: hexojs/site#649 [3]: gatsbyjs/gatsby#8221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR that adds a meta generator tag utilizing the current version of gatsby specified in node_modules/gatsby/package.json.
This will be useful for analytics, seeing what % of Gatsby sites have migrated (since this won't be in Gatsby v1 sites), etc. etc.