Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www] doesn't show selected state along top nav bar #7425

Closed
shannonbux opened this issue Aug 17, 2018 · 6 comments · Fixed by #7933
Closed

[www] doesn't show selected state along top nav bar #7425

shannonbux opened this issue Aug 17, 2018 · 6 comments · Fixed by #7933
Assignees

Comments

@shannonbux
Copy link
Contributor

shannonbux commented Aug 17, 2018

Initial problem

Many users, when they are on the Tutorial page, can't remember how to get back to Docs.

In an effort to solve this issue, I made a link to the Main Tutorial under Quick Start category in Docs. I also made a link to the Quick Start doc at the top of the Tutorial sidebar.

It appears this has created more confusion and didn't solve the initial problem. So that's getting taken care of in Issue #7424

Let's make sure we make the selected state along the top nav bar clear and see if it solves the initial problem.

@arzafran
Copy link

Let me know if I understood well and my approach fixes the issue.

@fk
Copy link
Contributor

fk commented Aug 20, 2018

Thanks for adding this @shannonbux! 🙏

@fk
Copy link
Contributor

fk commented Aug 20, 2018

Hey @arzafran! 👋
Thank you for your PR, looking good! 🤗

Coincidentially I also took a look at this over the weekend. I didn't even consider using font-weight: bold because I thought that it would cause the sibling nav items to "jump", but your PR looks nice -- much less of an issue than I thought!

FWIW I added some mockups showing some variants (for both (basically interchangable) "selected" and "hover" states):

bildschirmfoto 2018-08-20 um 16 54 09

@arzafran
Copy link

Nice Mockups!
I just took the easiest approach but you're right it makes the page 'jump' a little. but since paddings were a little off making any background decoration look misaligned I went with it and just used the font-weight to know if my idea was in the right direction.

@fk
Copy link
Contributor

fk commented Aug 20, 2018

Nice Mockups!
I just took the easiest approach […]

Thank you! And: Nothing wrong with the easiest approach -- super happy you're working on this!

but since paddings were a little off making any background decoration look misaligned

Oh yeah, I saw that, too. 😁
Feel free to change that if you want to take another look!

@fk
Copy link
Contributor

fk commented Aug 30, 2018

Just stumbled upon #2516 :-/ 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants