fix(gatsby-remark-images): Do not fallback title value to alt value #37395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tyhopp
added
topic: remark/mdx
LekoArts
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While the HTML img spec does not mention the case of duplicate
altandtitleattributes on animgelement (that I can find), MDN does mention we shouldn't do that so that screen readers do not make duplicate announcements.The HTML spec general guidelines say that
titleis fine as supplemental information, so we want to keep the ability to set bothaltandtitle, just not default the value oftitletoaltiftitleis not explicitly set in markdown.Setting the default of
titleto an empty string means that theimgelement will not inherit from its parent, which is probably what we want by default to avoid unintended title inheritance. If users want a title they have the ability to set it directly.Documentation
N/A
Related Issues
Resolves #37338