-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-transformer-remark): Activate footnotes by default & remove included options with remark v13 #31019
fix(gatsby-transformer-remark): Activate footnotes by default & remove included options with remark v13 #31019
Conversation
I don't believe the CI errors are related to this PR as they seem inconsistent, but if a maintainer feels otherwise, please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! 💜 Please ignore CI errors - they are unrelated. I've added a minor request for changes to avoid another breaking change in minor/patch. Otherwise, it looks good to me and we can definitely merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙏
…e included options with remark v13 (#31019) (#31080) * fix footnotes in gatsby-transformer-remark * fix tests * fix example * allow any value for deprecated parameters (cherry picked from commit a35d615) Co-authored-by: Frank Showalter <[email protected]>
…e included options with remark v13 (gatsbyjs#31019) * fix footnotes in gatsby-transformer-remark * fix tests * fix example * allow any value for deprecated parameters
Description
Re-enables footnotes in gatsby-transformer-remark and removes options removed from Remark in 13.0.0.
Documentation
https://github.com/fshowalter/gatsby/blob/topics/fix-footnotes-in-gatsby-transformer-remark/packages/gatsby-transformer-remark/README.md
Related Issues
Fixes #30964.