Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-transformer-remark): Activate footnotes by default & remove included options with remark v13 #31019

Conversation

fshowalter
Copy link
Contributor

Description

Re-enables footnotes in gatsby-transformer-remark and removes options removed from Remark in 13.0.0.

Documentation

https://github.com/fshowalter/gatsby/blob/topics/fix-footnotes-in-gatsby-transformer-remark/packages/gatsby-transformer-remark/README.md

Related Issues

Fixes #30964.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 23, 2021
@fshowalter
Copy link
Contributor Author

I don't believe the CI errors are related to this PR as they seem inconsistent, but if a maintainer feels otherwise, please let me know.

@LekoArts LekoArts added topic: remark/mdx Related to Markdown, remark & MDX ecosystem and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 26, 2021
@LekoArts LekoArts changed the title [Fix #30964] fix footnotes in gatsby-transformer-remark fix(gatsby-transformer-remark): Activate footnotes by default & remove included options with remark v13 Apr 26, 2021
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! 💜 Please ignore CI errors - they are unrelated. I've added a minor request for changes to avoid another breaking change in minor/patch. Otherwise, it looks good to me and we can definitely merge it.

@vladar vladar self-assigned this Apr 26, 2021
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@vladar vladar merged commit a35d615 into gatsbyjs:master Apr 27, 2021
vladar pushed a commit that referenced this pull request Apr 27, 2021
…e included options with remark v13 (#31019)

* fix footnotes in gatsby-transformer-remark

* fix tests

* fix example

* allow any value for deprecated parameters

(cherry picked from commit a35d615)
vladar pushed a commit that referenced this pull request Apr 27, 2021
…e included options with remark v13 (#31019) (#31080)

* fix footnotes in gatsby-transformer-remark

* fix tests

* fix example

* allow any value for deprecated parameters

(cherry picked from commit a35d615)

Co-authored-by: Frank Showalter <[email protected]>
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
…e included options with remark v13 (gatsbyjs#31019)

* fix footnotes in gatsby-transformer-remark

* fix tests

* fix example

* allow any value for deprecated parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: remark/mdx Related to Markdown, remark & MDX ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-transformer-remark lost footnotes with #29678
3 participants