feat(gatsby): move sync-requires to async-requires in develop #29391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
status: needs core review
wardpeet
added
topic: core
wardpeet
force-pushed
the
v3/dev-loader-async-requires
branch
from
12fded7 to
876b77c
Compare
pieh
approved these changes
Feb 22, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move sync-requires to async-requirres, this is necessary to make webpack v5 upgrade work with the new static query mapper.
I moved it out to make the webpack 5 PR easier to review.
It doesn't change much so that's good. I didn't do multiple runs as I didn't expect that.
Before:
After:
