perf: implement shouldOnCreateNode for all our plugins/benchmarks #27545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pvdz
added
topic: performance
pvdz
commented
Oct 19, 2020
pvdz
force-pushed
the
addSOCN
branch
6 times, most recently
from
5d41c9c to
d497458
Compare
vladar
previously approved these changes
Oct 20, 2020
LekoArts
previously approved these changes
Oct 20, 2020
|
Published as part of one of the following: |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…tsbyjs#27545) * perf: implement shouldOnCreateNode for all our plugins * Drop changes in /benchmarks, fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup for #27442 which introduced a
shouldOnCreateNodeAPI to test whether the asynconCreateNodecallback ought to be called.This PR implements this hook for all the plugins in our monorepo and some benchmark sites.
For all plugins, the behavior should remain the same and should be backwards compatible since the check also exists in the
onCreateNodehook itself.If a plugin happens to break, anyways, please try to fix forward rather than revert this whole PR. Thanks :)