Names for External Guest Users

[gary-kim]

When a guest joins a public ally accessible room in Talk, the display name does not display (Guest).

It is currently not possible to figure out if a user is a guest or user on the instance so this should be added. Once that's added, projects using the library can use that information to append (Guest) for guest users.

It could also be useful to add a DisplayName() function that will automatically append (Guest).

go-nc-talk/ocs/message.go

Lines 36 to 46 in ee3c5d2

	// TalkRoomMessageData describes the data part of a ocs response for a Talk room message
	type TalkRoomMessageData struct {
	Message string `json:"message"`
	ID int `json:"id"`
	ActorID string `json:"actorId"`
	ActorDisplayName string `json:"actorDisplayName"`
	SystemMessage string `json:"systemMessage"`
	Timestamp int `json:"timestamp"`
	MessageType MessageType `json:"messageType"`
	MessageParameters map[string]RichObjectString `json:"-"`
	}

cc @nickvergessen

[nickvergessen]

Pseudo code:

if ActorID starts with guest/ then
  if ActorDisplayName.empty then
    return 'Guest'
  else
    return ActorDisplayName.append(' (Guest)')
  fi
else
// current handling
fi

[gary-kim]

That'd be good. I was thinking we could also add the actorType field as a ActorType type.