New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data view loading optimizations #148

Merged

garrylachman merged 1 commit into develop from 147-loading-view-lagging

Mar 16, 2023

Owner

garrylachman commented Mar 16, 2023 •

edited

Loading

close #147

PR summary:

Refactored code in multiple files to improve performance and reliability
Implemented ReactDataGrid to display data
Added unique IDs to menu items and set isLazy to fixed
Added text to loading spinner


          Data view loading optimizations

09b632c

garrylachman self-assigned this

garrylachman linked an issue

that may be closed by this pull request

Loading view lagging #147

Closed

github-actions bot reviewed

View reviewed changes

packages/buttons/lib/actions-dropdown-menu.js Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

packages/buttons/lib/index.js Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

packages/buttons/src/actions-dropdown-menu.tsx Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/renderer/components/icons/inline-spinner.tsx Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/renderer/containers/filter-builder/filter-builder-wheres-group.tsx

		@@ -132,7 +132,7 @@ export const FilterBuilderWheresGroup: FC<FilterBuilderGroupProperties> = ({
		index={index + 1}

github-actions bot Mar 16, 2023

GPT summary of 888ad2 - a9cde2:

Changed the loading spinner to include text "Working..."

github-actions bot reviewed

View reviewed changes

src/renderer/containers/filter-builder/index.tsx Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/renderer/ipc/base-request.ts Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/renderer/views/admin/views/data/dashboard-context.tsx Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/renderer/views/admin/views/data/data-table/data-table-card.tsx Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/renderer/views/admin/views/data/data-table/data-table-header.tsx Show resolved Hide resolved

github-actions bot commented Mar 16, 2023

GPT summary of 09b632c:

Error: couldn't generate summary

PR summary so far:

Refactored code in multiple files to improve performance and reliability
Implemented ReactDataGrid to display data
Added unique IDs to menu items and set isLazy to fixed
Added text to loading spinner

garrylachman merged commit 338d784 into develop

garrylachman deleted the 147-loading-view-lagging branch

March 16, 2023 18:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet