Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To dynamically load IaaS credentials during runtime using secrets mount. #301

Merged
merged 4 commits into from
Mar 18, 2022
Merged

To dynamically load IaaS credentials during runtime using secrets mount. #301

merged 4 commits into from
Mar 18, 2022

Conversation

ishan16696
Copy link
Member

@ishan16696 ishan16696 commented Mar 4, 2022 •
edited
Loading

What this PR does / why we need it:
This PR integrates the feature to dynamically load IaaS credentials during runtime using secret file mount with etcd-druid.

Which issue(s) this PR fixes:
Fixes #422

Special notes for your reviewer:

Release note:

To Dynamically load Iaas credentials, added support to pass the credentials through secret mount.
Set File Path through Env: `<ProviderName>_APPLICATION_CREDENTIALS`

@ishan16696 ishan16696 requested a review from a team as a code owner March 4, 2022 08:22
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 4, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 4, 2022
@ishan16696 ishan16696 added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Mar 4, 2022
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 7, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 7, 2022
@ishan16696 ishan16696 force-pushed the integrate/secretsFromFile branch from 10fe03a to 65b3879 Compare March 9, 2022 05:51
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 9, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 9, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 9, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 9, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 9, 2022
@gardener-robot gardener-robot added the size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) label Mar 9, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 9, 2022
@ishan16696 ishan16696 changed the title [WIP]To dynamically load IaaS credentials during runtime using secrets mount. To dynamically load IaaS credentials during runtime using secrets mount. Mar 9, 2022
@gardener-robot gardener-robot removed the size/l Size of pull request is large (see gardener-robot robot/bots/size.py) label Mar 9, 2022
@plkokanov
Copy link
Contributor

I ran a control plane migration test on azure, and copying etcd backups seems to work fine with the new way that secrets are used now.

@aaronfern
Copy link
Contributor

I tested compaction jobs on aws, az, and gcp, and they all ran ok with these new secret changes

@ishan16696 ishan16696 force-pushed the integrate/secretsFromFile branch from 52db5d8 to 0035330 Compare March 18, 2022 10:08
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 18, 2022
@ishan16696
Copy link
Member Author

ishan16696 commented Mar 18, 2022 •
edited
Loading

I have rebase my PR on latest master.
@aaronfern can you take a re-look, I will also re-test it on every provider.

@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 18, 2022
aaronfern
aaronfern approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 18, 2022
@aaronfern aaronfern removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Mar 18, 2022
@ishan16696 ishan16696 merged commit 3566f7b into gardener:master Mar 18, 2022
@ishan16696 ishan16696 deleted the integrate/secretsFromFile branch April 1, 2022 05:40
@ishan16696 ishan16696 mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfern aaronfern aaronfern approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Dynamically load IaaS credentials during runtime
7 participants
@ishan16696 @plkokanov @aaronfern @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot