Fixed a bug which causes restoration to fail when first delta snapshot completely overlaps latest full snapshot. #845
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…completely overlaps latest full snapshot.
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
|
I'm yet to add the unit tests for this scenario. |
gardener-robot
added
the
reviewed/do-not-merge
ishan16696
removed
the
reviewed/do-not-merge
|
I will not be able to add unit tests for this, I can add unit tests for this later. Let's not block the fix. |
shreyas-s-rao
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
@ishan16696 thanks for the fix! I've tested this and it fixes the issue of overlapping revisions as mentioned.
/lgtm
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area disaster-recovery
/kind bug
What this PR does / why we need it:
This PR fixes a bug which causes restoration to fail when first delta snapshot completely overlaps latest full snapshot.
Which issue(s) this PR fixes:
Fixes #844
Special notes for your reviewer:
Release note: