From fd18b36ff16dbcbad64cfb55488f19dad60d7884 Mon Sep 17 00:00:00 2001 From: Ishan Tyagi Date: Fri, 10 Feb 2023 18:12:56 +0530 Subject: [PATCH] Address review comments 2. --- pkg/snapshot/snapshotter/snapshotter.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/snapshot/snapshotter/snapshotter.go b/pkg/snapshot/snapshotter/snapshotter.go index 8a2846749..ccfb9dece 100644 --- a/pkg/snapshot/snapshotter/snapshotter.go +++ b/pkg/snapshot/snapshotter/snapshotter.go @@ -793,11 +793,11 @@ func (ssr *Snapshotter) GetFullSnapshotMaxTimeWindow(fullSnapScheduleSpec string return defaultFullSnapMaxTimeWindow } - if schedule[dayOfMonth] == "*" && schedule[dayOfWeek] == "*" && !strings.Contains(schedule[hour], "/") { - return defaultFullSnapMaxTimeWindow - } else if schedule[dayOfWeek] != "*" { + if schedule[dayOfWeek] != "*" { return defaultFullSnapMaxTimeWindow * 7 - } else if schedule[dayOfMonth] == "*" && schedule[dayOfWeek] == "*" && strings.Contains(schedule[hour], "/") { + } + + if schedule[dayOfMonth] == "*" && schedule[dayOfWeek] == "*" && strings.Contains(schedule[hour], "/") { if timeWindow, err := strconv.ParseFloat(schedule[hour][strings.Index(schedule[hour], "/")+1:], 64); err == nil { return timeWindow }