Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change hexdump_iter to not rely on the length of its input file #850

Merged
merged 3 commits into from
Jan 12, 2017
Merged

Change hexdump_iter to not rely on the length of its input file #850

merged 3 commits into from
Jan 12, 2017

Conversation

zachriggle
Copy link
Member

@zachriggle zachriggle commented Jan 12, 2017 •
edited
Loading

We cannot determine the length of the file if passed e.g. a tube or a pipe or or PTY or character device (e.g. stdin or /dev/null).

Supercedes: 9c2f0f4
Picked from dev: 14f717b

@zachriggle zachriggle added the bug label Jan 12, 2017
@zachriggle zachriggle added this to the 3.3.0 milestone Jan 12, 2017
@zachriggle
Copy link
Member Author

This fixes the bug which caused phd to fail silently when reading from stdin

@zachriggle
Change hexdump_iter to not rely on the length of its input file
aa385c2 
We cannot determine the length of the file if passed e.g. a tube or a pipe or
or PTY or character device (e.g. stdin or /dev/null).

Supercedes: 9c2f0f4
(cherry picked from commit 14f717b)
@zachriggle zachriggle force-pushed the hexdump-iter-without-size branch from c6554ac to aa385c2 Compare January 12, 2017 20:02
@TethysSvensson
Copy link
Contributor

I am not sure about the actual code, but I've tested hexdump on strings, hexdump_iter on process and file and tested phd with an argument and using data on stdin.

Could we have command line tests as part of travis?

@zachriggle
Copy link
Member Author

I'm not sure how to fit command-line tests into our current testing infrastructure 🤷‍♂️

@zachriggle zachriggle merged commit 16b507e into Gallopsled:stable Jan 12, 2017
@zachriggle zachriggle deleted the hexdump-iter-without-size branch January 12, 2017 22:20
Kyle-Kyle pushed a commit to Kyle-Kyle/pwntools that referenced this pull request Apr 25, 2021
@fishykz
fix for ubuntu 20.04 (Gallopsled#850)
cfe93ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TethysSvensson TethysSvensson TethysSvensson approved these changes

Assignees

@zachriggle zachriggle

@TethysSvensson TethysSvensson

Labels
backport-complete bug
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zachriggle @TethysSvensson