-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(exchange): change pallet errors #271
fix(exchange): change pallet errors #271
Conversation
This issue looked very simple, but when it's about namings of public interfaces - you should understand all code around it pretty well to give good names. I was trying to figure out how exchange pallete works, but it's not too easy :) so I'm not sure that I've solved the issue correctly. |
Also I don't know is changing of errors a breaking change? |
This looks ok , except the new IncorrectMatch error. However, there is a bug in this area #274 ( fix coming soon ) which will likely to make some changes in this area. So, let's first fix that bug and then make changes in this PR. |
Yes, it is. Ui has some expectations about error names to display valid translations etc. One you change it, fronted needs to be updated accordingly. So you also need to update the palette version |
Actually, UI shows errors based on |
2dd1beb
to
d1c4fd8
Compare
d1c4fd8
to
c91fee0
Compare
Description
AssetBalanceLimitExceeded
is splitted into two errors, one for sell case and one for buy.Fixes: #268
Motivation and Context
There was only one error for two different cases and error name itself was not accurate. Two different errors helps to better indicate what's the problem and when it actually occurs.
How Has This Been Tested?
Run tests locally, fixed the broken one.
Checklist: