Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change Price type #235

Merged
merged 5 commits into from
May 1, 2021
Merged

feat: change Price type #235

merged 5 commits into from
May 1, 2021

Conversation

martinfridrich
Copy link
Contributor

@auto-add-label auto-add-label bot added the type/enhancement New feature or request label Apr 29, 2021
@Roznovjak
Copy link
Contributor

Is this part of the docs still valid?

mrq1911
mrq1911 approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@mrq1911 mrq1911 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i would recommend re-benchmarking after this change. i see that this is in progress in #210

@mrq1911 mrq1911 merged commit d48b28d into master May 1, 2021
@jak-pan jak-pan deleted the feat/price_type_change branch May 9, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrq1911 mrq1911 mrq1911 approved these changes

@enthusiastmartin enthusiastmartin Awaiting requested review from enthusiastmartin

@jak-pan jak-pan Awaiting requested review from jak-pan

@green-jay green-jay Awaiting requested review from green-jay

@Roznovjak Roznovjak Awaiting requested review from Roznovjak

Assignees
No one assigned
Labels
type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinfridrich @Roznovjak @mrq1911