Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): configure justification import for full node #225

Conversation

andresilva
Copy link
Contributor

As part of my investigation in paritytech/substrate#4678 (comment), I also found that this was wrong (although it doesn't fix the original issue).

@auto-add-label auto-add-label bot added the node label Apr 27, 2021
@andresilva
Copy link
Contributor Author

Moving the discussion from paritytech/substrate#4678 (comment) to here. I believe a possible solution to this could be as follows:

  • Resync all (or a >2/3 majority) validators from scratch. They should be able to sync to the latest block (#161136) but should all get stuck at best finalized block #104960.
  • Once that's done trigger a forced change through the note_stalled API using block #104960 as the best finalized block number.
  • Any existing client will need to resync as this will be reverting finality.

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
I am not sure whether the above will work. It seems that you have sudo on this network so please just test this locally before trying it on the actual network. This will be easier to do if you have a small validator set that you control completely. Since you have sudo you could temporarily reduce the number of validators and make sure only your nodes are in the set. Even if it does work I think people that sync from scratch from then on will be seeing some temporary Invalid justification errors (that are expected).

@mrq1911 mrq1911 changed the title node: configure justification import for full node fix(node): configure justification import for full node Apr 27, 2021
@auto-add-label auto-add-label bot added bug and removed node labels Apr 27, 2021
@mrq1911 mrq1911 merged commit 98f0299 into galacticcouncil:master May 1, 2021
@mrq1911 mrq1911 mentioned this pull request May 1, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants