Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(amm): changed event names to past tense #215

Merged
merged 7 commits into from
May 1, 2021
Merged

refactor(amm): changed event names to past tense #215

merged 7 commits into from
May 1, 2021

Conversation

jareknowotka
Copy link
Contributor

Description

AMM pallet was using present tense event names. To keep them consistent with other pallets and general substrate convention of using past tense.

Related Issue

Fixes: #180

@enthusiastmartin enthusiastmartin self-requested a review April 19, 2021 09:26
Copy link
Contributor

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's finalize the event name format and after that, looks good.

README.md Outdated Show resolved Hide resolved
pallets/amm/README.md Outdated Show resolved Hide resolved
pallets/amm/README.md Outdated Show resolved Hide resolved
Copy link
Member

@mrq1911 mrq1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump spec version and LGTM

@mrq1911 mrq1911 merged commit c65c3d9 into galacticcouncil:master May 1, 2021
@jareknowotka jareknowotka deleted the refactor/amm-events branch May 2, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: consolidate pallet event names
4 participants