feat!: genesis history pallet #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jak-pan
reviewed
Apr 8, 2021
| impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {} | ||
|
|
||
| #[pallet::call] | ||
| impl<T:Config> Pallet<T> {} |
There was a problem hiding this comment.
Is this actually required? (I can see it could be.)
There was a problem hiding this comment.
yes, macro requires it, same as hooks, but it isn't actually used in runtime. interestingly, events are not required.
auto-add-label
bot
added
00-breaking-change
and removed
type/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pallet provides simple storage linking to the previous chain genesis and last block hash.
required by #191 #192
TODO
Note
feel free to change PR target, this targets master for workflow to run (also is based on master)
Types are generic bytes for maximal compatibility, alternatively, it could be Hash type. Also
PreviousChaincould be posibly unwrapped into two storage values in pallet.