-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add contributing guidelines #144
docs: add contributing guidelines #144
Conversation
Get changes from base repo
Merge master
Merge master
Merge master
Tried to keep it simple, suggestions welcome :) |
adjusted README & CONTRIBUTING
I've updated the contributing guide to be more precise and did some other small changes. If we're OK with this please merge the new stuff here also: https://github.com/galacticcouncil/guidelines-example |
i was wondering the same thing, thanks for the feedback. |
We need to change the conventional commit messages enforcement from any commit to just PR names. https://github.com/zeke/semantic-pull-requests#configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor two comments. otherwise looks goo.d
|
||
### Your Environment | ||
<!--- Include as many relevant details about the environment you experienced the bug in --> | ||
* Version used: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Info about how to get the actual version might be useful too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to keep this generic and push to every project so that we can sync this.
I'm happy with this right now. Will merge this. We can open new PRs for additions/updates. Thank you guys, especially @RoboRambo ! |
…draDX-node into add_contributing_guidelines
Partially resolves #121