Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Adapt to the modification of engine Texture #362

Merged
merged 11 commits into from
Apr 22, 2022
Merged

Adapt to the modification of engine Texture #362

merged 11 commits into from
Apr 22, 2022

Conversation

GuoLei1990
Copy link
Member

@GuoLei1990 GuoLei1990 commented Mar 29, 2022 •
edited
Loading

Adapter PR:
galacean/engine#715

@GuoLei1990 GuoLei1990 requested a review from zhuxudong March 29, 2022 11:02
@GuoLei1990 GuoLei1990 self-assigned this Mar 29, 2022
@GuoLei1990 GuoLei1990 added this to the 0.7 milestone Mar 29, 2022
@GuoLei1990 GuoLei1990 changed the title Adapter to 0.7 engine Adapt to the modification of engine Texture Mar 29, 2022
zhuxudong
zhuxudong approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@zhuxudong zhuxudong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhuxudong
Copy link
Member

zhuxudong commented Mar 30, 2022 •
edited
Loading

pls note that IBL-baker demo is depended on https://github.com/oasis-engine/engine-baker/pull/1

@zhuxudong zhuxudong mentioned this pull request Apr 11, 2022
Closed
GuoLei1990
GuoLei1990 commented Apr 18, 2022
View reviewed changes
playground/multi-viewport.ts
"https://gw.alipayobjects.com/mdn/rms_7c464e/afts/img/A*CYGZR7ogZfoAAAAAAAAAAAAAARQnAQ"
],
type: AssetType.TextureCube
})
.then((cubeMap1) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename "textureCube"

@zhuxudong zhuxudong merged commit d93588d into galacean:dev/0.7 Apr 22, 2022
@GuoLei1990 GuoLei1990 deleted the pr/opt-texture branch November 24, 2022 04:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zhuxudong zhuxudong zhuxudong approved these changes

@eyworldwide eyworldwide Awaiting requested review from eyworldwide

@cptbtptpbcptdtptp cptbtptpbcptdtptp Awaiting requested review from cptbtptpbcptdtptp

Assignees

@GuoLei1990 GuoLei1990

Labels
None yet
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@GuoLei1990 @zhuxudong @eyworldwide @singlecoder