Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix entity and glTF destroy bug #629

Merged
merged 3 commits into from
Jan 5, 2022
Merged

fix entity and glTF destroy bug #629

merged 3 commits into from
Jan 5, 2022

Conversation

GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@GuoLei1990 GuoLei1990 requested review from yangfengzzz, gz65555, zhuxudong and a team January 5, 2022 08:55
gz65555
gz65555 approved these changes Jan 5, 2022
View reviewed changes
Copy link
Collaborator

@gz65555 gz65555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 requested a review from singlecoder January 5, 2022 09:02
singlecoder
singlecoder approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@singlecoder singlecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit 041f94b into galacean:dev/0.6-plus Jan 5, 2022
@GuoLei1990 GuoLei1990 linked an issue Jan 28, 2022 that may be closed by this pull request
ResourceManager cache bug #609
Closed
@GuoLei1990 GuoLei1990 deleted the dev/0.6-plus branch July 28, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gz65555 gz65555 gz65555 approved these changes

@singlecoder singlecoder singlecoder approved these changes

@yangfengzzz yangfengzzz Awaiting requested review from yangfengzzz

@zhuxudong zhuxudong Awaiting requested review from zhuxudong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResourceManager cache bug
3 participants
@GuoLei1990 @gz65555 @singlecoder