Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image reference #432

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

PlateArmourProgrammer
Copy link
Contributor

@PlateArmourProgrammer PlateArmourProgrammer commented Aug 13, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

fix image elements won't be garbage collected after onload callback

Copy link
Member

@GuoLei1990 GuoLei1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 requested a review from gz65555 August 16, 2021 03:54
Copy link
Collaborator

@gz65555 gz65555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 closed this Aug 16, 2021
@GuoLei1990 GuoLei1990 reopened this Aug 16, 2021
@GuoLei1990 GuoLei1990 merged commit e8c4c58 into galacean:main Aug 16, 2021
luzhuang pushed a commit to luzhuang/engine that referenced this pull request Sep 6, 2022
* fix: image reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants