fix: load gltf has no material #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyworldwide
reviewed
Jul 29, 2021
| const material = materials[i]; | ||
| let materialResource = null; | ||
| let type = ""; | ||
| if (materials && materials.length) { |
There was a problem hiding this comment.
Tip: use typescript's feature. materials?.length
Codecov Report
@@ Coverage Diff @@
## main #408 +/- ##
==========================================
+ Coverage 44.68% 44.85% +0.17%
==========================================
Files 314 314
Lines 17496 17426 -70
Branches 2343 2328 -15
==========================================
- Hits 7818 7817 -1
+ Misses 9678 9609 -69
Continue to review full report at Codecov.
|
GuoLei1990
approved these changes
Jul 30, 2021
| @@ -38,9 +38,6 @@ export class TextureResource extends SchemaResource { | |||
| setMeta() { | |||
| if (this.resource) { | |||
| this._meta.name = this.resource.name; | |||
| if (this.resource.image) { | |||
| this._meta.url = this.resource.image.src; | |||
| } | |||
There was a problem hiding this comment.
This resource is any, we should fix this later. @gz65555
luzhuang
pushed a commit
to luzhuang/engine
that referenced
this pull request
Sep 6, 2022
* fix: load gltf has no material
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: