Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delete tween package #329

Merged
merged 1 commit into from
Jun 11, 2021
Merged

refactor: delete tween package #329

merged 1 commit into from
Jun 11, 2021

Conversation

GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Delete tween package.

@GuoLei1990 GuoLei1990 requested a review from a team June 11, 2021 13:57
@codecov-commenter
Copy link

Codecov Report

Merging #329 (c6b7128) into main (54b7eb0) will increase coverage by 1.33%.
The diff coverage is n/a.

❗ Current head c6b7128 differs from pull request most recent head f742511. Consider uploading reports for the commit f742511 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   40.62%   41.95%   +1.33%     
==========================================
  Files         330      313      -17     
  Lines       18395    17751     -644     
  Branches     2427     2312     -115     
==========================================
- Hits         7473     7448      -25     
+ Misses      10921    10303     -618     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
packages/loader/src/gltf/parser/MaterialParser.ts 0.00% <0.00%> (-16.00%) ⬇️
packages/loader/src/gltf/parser/SceneParser.ts 0.00% <0.00%> (-12.95%) ⬇️
...ader/src/scene-loader/resources/TextureResource.ts 0.00% <0.00%> (-6.90%) ⬇️
packages/draco/src/decoder.ts 0.00% <0.00%> (ø)
packages/loader/src/scene-loader/Oasis.ts 0.00% <0.00%> (ø)
...ackages/loader/src/scene-loader/ResourceManager.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b7eb0...f742511. Read the comment docs.

Copy link
Member

@singlecoder singlecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit df8d418 into galacean:main Jun 11, 2021
luzhuang pushed a commit to luzhuang/engine that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants