Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glTFModel error #309

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Fix glTFModel error #309

merged 1 commit into from
Jun 7, 2021

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented May 31, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

fix editor gltf enabled not take effect when refresh page.

@gz65555 gz65555 requested review from GuoLei1990 and zhuxudong May 31, 2021 03:51
GuoLei1990
GuoLei1990 approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@GuoLei1990 GuoLei1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit ce71d73 into galacean:main Jun 7, 2021
luzhuang pushed a commit to luzhuang/engine that referenced this pull request Sep 6, 2022
@gz65555
refactor: fix gltf is not show (galacean#309)
220a26f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

@zhuxudong zhuxudong Awaiting requested review from zhuxudong

Assignees
No one assigned
Labels
None yet
Projects
GLTF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gz65555 @GuoLei1990