feat: add ortho control for camera #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singlecoder
requested review from
eyworldwide,
GuoLei1990,
gz65555,
cptbtptpbcptdtptp and
zhuxudong
… feat/camera-control
gz65555
reviewed
May 20, 2021
| @@ -0,0 +1,136 @@ | |||
| import { Camera, Entity, Script, Vector2, Vector3 } from "oasis-engine"; | |||
|
|
|||
| return Math.pow(0.95, this.zoomSpeed); | ||
| } | ||
|
|
||
| private _handlePan(): void { |
There was a problem hiding this comment.
You should update camera transform in onUpdate function to avoid unnecessary calculation. use a flag to mark whether to update transform.
gz65555
reviewed
Jun 8, 2021
| } | ||
|
|
||
| onUpdate(dt: number): void { | ||
| if (!this.enabled) return; |
There was a problem hiding this comment.
no need for enabled is false
gz65555
reviewed
Jun 8, 2021
| */ | ||
| export class OrthoControl extends Script { | ||
| camera: Entity; | ||
| cameraComp: Camera; |
Codecov Report
@@ Coverage Diff @@
## dev/0.4 #278 +/- ##
===========================================
+ Coverage 40.47% 40.68% +0.21%
===========================================
Files 328 329 +1
Lines 18283 18288 +5
Branches 2413 2405 -8
===========================================
+ Hits 7400 7441 +41
+ Misses 10882 10847 -35
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
gz65555
reviewed
Jun 8, 2021
| private _zoomScaleUnit: number = 25.0; | ||
| private _zoomMinSize: number = 0.0; | ||
| private _zoomMaxSize: number = Infinity; | ||
| private _isPanStart: boolean = false; |
gz65555
reviewed
Jun 8, 2021
| const { _panStart: panStart, _panEnd: panEnd } = this; | ||
| Vector2.subtract(panEnd, panStart, this._panDelta); | ||
| this._handlePan(); | ||
| panEnd.cloneTo(panStart); |
| * @param y - The y-axis coordinate (unit: pixel) | ||
| */ | ||
| panMove(x: number, y: number): void { | ||
| if (this.enabled === false || this._isPanStart === false) return; |
| * @param y - The y-axis coordinate (unit: pixel) | ||
| */ | ||
| panMove(x: number, y: number): void { | ||
| if (this.enabled === false || this._isPanStart === false) return; |
| private _handlePan(): void { | ||
| const { width, height } = this.engine.canvas; | ||
| const { x, y } = this._panDelta; | ||
| const { camera: cameraComp } = this; |
| */ | ||
| panMove(x: number, y: number): void { | ||
| if (this.enabled === false || this._isPanStart === false) return; | ||
| this._panEnd.setValue(x, y); |
luzhuang
pushed a commit
to luzhuang/engine
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements